Skip to content

Conversation

@mcsi-odoo
Copy link
Contributor

task-3491855

@robodoo
Copy link
Collaborator

robodoo commented Nov 4, 2025

Pull request status dashboard

@C3POdoo C3POdoo requested a review from a team November 4, 2025 12:50
@mcsi-odoo mcsi-odoo requested review from a team and removed request for a team November 4, 2025 12:52
Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear and thorough as usual :) Plus nice use of examples/illustrations :)

Comment on lines 34 to 35
#. Click below :guilabel:`Apply to range`, then, in the spreadsheet, select the range of cells the
formatting rule should apply on. Click :guilabel:`Confirm`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose most people would begin by selecting the range in the spreadsheet and then applying the formatting, so I would start with that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Thanks. I'll update the order.

With the range selected and :guilabel:`Icon set` selected as the rule type:

#. Click on the set of :guilabel:`Icons` to use.
#. For the first two icons listed, define the conditions to be met for the icon to be shown, e.g.,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the other types of formatting are thoroughly explained, I would also explain how to define the condition (select > or ≥ ...).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point. I've revised the instructions and example to make this clearer.

Copy link
Contributor Author

@mcsi-odoo mcsi-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! PR updated accordingly :)

Comment on lines 34 to 35
#. Click below :guilabel:`Apply to range`, then, in the spreadsheet, select the range of cells the
formatting rule should apply on. Click :guilabel:`Confirm`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Thanks. I'll update the order.

With the range selected and :guilabel:`Icon set` selected as the rule type:

#. Click on the set of :guilabel:`Icons` to use.
#. For the first two icons listed, define the conditions to be met for the icon to be shown, e.g.,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point. I've revised the instructions and example to make this clearer.

@mcsi-odoo mcsi-odoo force-pushed the 19.0-spreadsheet-conditional-formatting-mcsi branch from 6160310 to 91cd9fc Compare November 13, 2025 10:29
@mcsi-odoo mcsi-odoo requested a review from xpl-odoo November 13, 2025 12:02
Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!
@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants